Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor protoparse, fixes multiple issues #316

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Commits on Apr 26, 2020

  1. refactor protoparse, fixes multiple issues:

    - defers a lot of validation to after the AST is fully constructed
    - in particular, defers tag validation to after message options are parsed
      in order to know if it has message_set_wire_format option, which impacts
      allowed tag range
    - fixes issues with very large constant numbers (that overflow uint64 or
      underflow int64)
    - refactors grammar around option names and fixes issue where extensions
      on message options aren't parsed correctly
    - fixes issues related to groups in oneofs
    - fixes issues with reserved name validation
    - adds some util methods to shrink the boiler-plate for error creation
      and error handling
    - breaks up monolithic parser.go into three files: parser.go, validation.go
      and descriptor_protos.go
    - adds numerous new validation test cases to catch various issues that
      were fixed
    jhump committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    31226ba View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Configuration menu
    Copy the full SHA
    32d5d84 View commit details
    Browse the repository at this point in the history