Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack to 2.2 #24

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
57 changes: 35 additions & 22 deletions lib/RewirePlugin.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use strict";

var path = require("path"),
ModuleAliasPlugin = require("enhanced-resolve/lib/ModuleAliasPlugin.js"),
AliasPlugin = require("enhanced-resolve/lib/AliasPlugin.js"),
RewiredNormalModuleFactory = require("./RewiredNormalModuleFactory.js"),
RewiredDependency = require("./RewiredDependency.js");

Expand All @@ -19,35 +19,48 @@ RewirePlugin.prototype.apply = function (compiler) {
});

// accept "var rewire", elsewise it would not be parsed (as overwritten)
compiler.parser.plugin("var rewire", function () {
return true;
compiler.plugin("compilation", function(compilation, data) {
data.normalModuleFactory.plugin("parser", function(parser, options) {
parser.plugin("var rewire", function () {
return true;
});
});
});

// find rewire(request: String) calls and bind our RewiredDependency
compiler.parser.plugin("call rewire", function (expr) {
var param,
dep;
compiler.plugin("compilation", function(compilation, data) {
data.normalModuleFactory.plugin("parser", function(parser, options) {
parser.plugin("call rewire", function (expr) {
var param,
dep;

if (expr.arguments.length !== 1) {
return false;
}
if (expr.arguments.length !== 1) {
return false;
}

param = this.evaluateExpression(expr.arguments[0]);
if (!param.isString()) {
return false;
}
param = this.evaluateExpression(expr.arguments[0]);
if (!param.isString()) {
return false;
}

dep = new RewiredDependency(param.string, param.range);
dep.loc = expr.loc;
this.state.current.addDependency(dep);
dep = new RewiredDependency(param.string, param.range);
dep.loc = expr.loc;
this.state.current.addDependency(dep);

return true;
return true;
});

});
});

// alias the require("rewire") to a webpack rewire
compiler.resolvers.normal.apply(new ModuleAliasPlugin({
rewire: path.join(__dirname, "rewire.web.js")
}));
compiler.plugin("after-resolvers", function() {
compiler.resolvers.normal.apply(
new AliasPlugin("described-resolve", {
name: "rewire",
alias: path.join(__dirname, "rewire.web.js"),
}, "resolve")
)
});
};

module.exports = RewirePlugin;
module.exports = RewirePlugin;
26 changes: 12 additions & 14 deletions lib/RewiredDependency.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
"use strict";

var Dependency = require("webpack/lib/Dependency.js");
const Dependency = require("webpack/lib/Dependency.js");

function RewiredDependency(request, range) {
Dependency.call(this);
this.request = request;
this.userRequest = request;
this.Class = RewiredDependency;
this.range = range;
}
class RewiredDependency extends Dependency {
constructor(request, range) {
super();
this.request = request;
this.userRequest = request;
this.range = range;
}

RewiredDependency.prototype = Object.create(Dependency.prototype);
RewiredDependency.prototype.type = "rewire";
RewiredDependency.prototype.constructor = RewiredDependency;
RewiredDependency.prototype.isEqualResource = function (other) {
return other instanceof RewiredDependency?
isEqualResource(other) {
return other instanceof RewiredDependency?
this.request === other.request:
false;
};
}
}

RewiredDependency.Template = require("webpack/lib/dependencies/ModuleDependencyTemplateAsId.js");

Expand Down
6 changes: 3 additions & 3 deletions lib/RewiredNormalModuleFactory.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ function RewiredNormalModuleFactory(factory) {
this.factory = factory;
}

RewiredNormalModuleFactory.prototype.create = function (context, dependency, callback) {
this.factory.create(context, dependency, function onModuleCreate(err, module) {
RewiredNormalModuleFactory.prototype.create = function (data, callback) {
this.factory.create(data, function onModuleCreate(err, module) {
if (err) {
return callback(err);
}
Expand All @@ -20,4 +20,4 @@ RewiredNormalModuleFactory.prototype.create = function (context, dependency, cal
});
};

module.exports = RewiredNormalModuleFactory;
module.exports = RewiredNormalModuleFactory;
2 changes: 1 addition & 1 deletion lib/rewire.web.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ function rewire(module) {
return rewiredModule.exports;
}

module.exports = rewire;
module.exports = rewire;
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@
"repository": "git://github.com/jhnns/rewire-webpack.git",
"license": "Unlicense",
"dependencies": {
"enhanced-resolve": "^0.9.1",
"webpack": "^1.12.6"
"enhanced-resolve": "^3.1.0",
"webpack": "^2.2.1"
},
"devDependencies": {
"expect.js": "^0.3.1",
"mocha": "^2.3.4",
"mocha-loader": "^0.7.1",
"mocha": "^3.2.0",
"mocha-loader": "^1.1.0",
"rewire": "^2.5.0",
"webpack-dev-server": "^1.12.1"
"webpack-dev-server": "^2.3.0"
},
"scripts": {
"test": "webpack-dev-server --config ./test/webpack.config.js"
Expand Down
4 changes: 2 additions & 2 deletions test/webpack.config.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
var RewirePlugin = require("../");

module.exports = {
entry: "mocha!" + __dirname + "/webpack.test.js",
entry: "mocha-loader!" + __dirname + "/webpack.test.js",
devtool: "eval",
plugins: [
new RewirePlugin()
]
};
};