Skip to content

Commit

Permalink
Remove node nightly tests warning checks
Browse files Browse the repository at this point in the history
(superseded by TypeStrong#1701)
  • Loading branch information
jhmaster2000 committed Mar 30, 2022
1 parent be25469 commit 228c4ed
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -69,8 +69,8 @@
"build-tsc": "tsc",
"build-configSchema": "typescript-json-schema --topRef --refs --validationKeywords allOf --out tsconfig.schema.json tsconfig.build-schema.json TsConfigSchema && node --require ./register ./scripts/create-merged-schema",
"build-pack": "node ./scripts/build-pack.js",
"test-spec": "ava --node-arguments=--no-deprecation",
"test-cov": "nyc ava --node-arguments=--no-deprecation",
"test-spec": "ava",
"test-cov": "nyc ava",
"test": "npm run build && npm run lint && npm run test-cov --",
"test-local": "npm run lint-fix && npm run build-tsc && npm run build-pack && npm run test-spec --",
"pre-debug": "npm run build-tsc && npm run build-pack",
Expand Down
10 changes: 2 additions & 8 deletions src/test/esm-loader.spec.ts
Expand Up @@ -350,10 +350,7 @@ test.suite('esm', (test) => {
const { err, stdout, stderr } = await cb();
expect(err).toBe(null);
expect(stdout.trim()).toBe('CLI args: foo bar');
// Nightly builds of Node.js might randomly start printing warnings,
// which would cause this test to fail despite actually working,
// so we should ignore stderr when testing on Node.js nightly.
if (!process.version.includes('nightly')) expect(stderr).toBe('');
expect(stderr).toBe('');
});
}

Expand Down Expand Up @@ -402,10 +399,7 @@ test.suite('esm', (test) => {
`child registered signal handlers\nchild received signal: ${signal}\nchild exiting`
);
}
// Nightly builds of Node.js might randomly start printing warnings,
// which would cause this test to fail despite actually working,
// so we should ignore stderr when testing on Node.js nightly.
if (!process.version.includes('nightly')) expect(stderr).toBe('');
expect(stderr).toBe('');
});
}
});
Expand Down

0 comments on commit 228c4ed

Please sign in to comment.