Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to vitest #3231

Merged
merged 1 commit into from Nov 2, 2022
Merged

Move to vitest #3231

merged 1 commit into from Nov 2, 2022

Conversation

Gnuk
Copy link
Collaborator

@Gnuk Gnuk commented Aug 24, 2022

No description provided.

@pascalgrimaud
Copy link
Member

I think it's a good move, we should try to achieve this

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Oct 6, 2022
@pascalgrimaud
Copy link
Member

@Gnuk : for your information, this PR #3866 can help

But there are still some issue, related to coverage

@Gnuk Gnuk force-pushed the move-to-vitest branch 2 times, most recently from e48280d to 92d0e25 Compare October 14, 2022 07:50
@Gnuk Gnuk force-pushed the move-to-vitest branch 7 times, most recently from 8b5f5aa to eb24e26 Compare October 26, 2022 13:56
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (26c1ded) compared to base (1517867).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #3231   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2129      2129           
===========================================
  Files            572       569    -3     
  Lines           9279      9255   -24     
  Branches         175       182    +7     
===========================================
- Hits            9279      9255   -24     
Impacted Files Coverage Δ
.../main/webapp/app/common/primary/timeout/Timeout.ts 100.00% <ø> (ø)
src/main/webapp/app/http/AxiosHttp.ts 100.00% <0.00%> (ø)
src/main/webapp/app/loader/primary/Loader.ts 100.00% <0.00%> (ø)
src/main/webapp/app/module/domain/Modules.ts 100.00% <0.00%> (ø)
src/main/webapp/app/common/domain/Memoizer.ts 100.00% <0.00%> (ø)
src/main/webapp/app/common/domain/Optional.ts 100.00% <0.00%> (ø)
src/main/webapp/app/common/domain/Statistics.ts 100.00% <0.00%> (ø)
src/main/webapp/app/module/domain/ModuleSlug.ts 100.00% <0.00%> (ø)
src/main/webapp/app/module/secondary/RestModule.ts 100.00% <0.00%> (ø)
...rc/main/webapp/app/module/secondary/RestModules.ts 100.00% <0.00%> (ø)
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gnuk Gnuk force-pushed the move-to-vitest branch 4 times, most recently from b25d30a to 4a57d77 Compare October 31, 2022 13:46
@Gnuk
Copy link
Collaborator Author

Gnuk commented Oct 31, 2022

Waiting for vitest-dev/vitest#2245 to be resolved before merging this one.

@Gnuk
Copy link
Collaborator Author

Gnuk commented Nov 2, 2022

It's now ready, thank you @AriPerkkio for the help on vitest :)

@Gnuk Gnuk marked this pull request as ready for review November 2, 2022 07:00
@pascalgrimaud pascalgrimaud added $500 https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ and removed $200 https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Nov 2, 2022
@pascalgrimaud pascalgrimaud merged commit 118900b into jhipster:main Nov 2, 2022
@Gnuk
Copy link
Collaborator Author

Gnuk commented Nov 2, 2022

I'll claim $300 fot this issue.

@Gnuk Gnuk deleted the move-to-vitest branch November 2, 2022 08:03
@pascalgrimaud
Copy link
Member

Thanks for your work @Gnuk and @AriPerkkio !!!

Plz follow this https://www.jhipster.tech/bug-bounties/#-bug-bounties to claim each part of bounty

As discussed between you, 300 for @Gnuk and 200 for you @AriPerkkio : hope it's ok :-)

Don't forget to comment this pull request with the open collective link, so I can approve it

@Gnuk
Copy link
Collaborator Author

Gnuk commented Nov 2, 2022

@AriPerkkio
Copy link

@pascalgrimaud
Copy link
Member

@Gnuk : approved

@pascalgrimaud
Copy link
Member

@AriPerkkio : approved :-)

@DamnClin
Copy link
Collaborator

DamnClin commented Nov 2, 2022

Played with it. The "setup" (npm run test:watch) is a little bit long but then we finally have acceptable feedback loops on TS tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $200 https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants