Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to avoid conflict of grabbing websocket port #5329

Merged
merged 2 commits into from Mar 1, 2017
Merged

Conversation

jhcao23
Copy link
Contributor

@jhcao23 jhcao23 commented Feb 28, 2017

both the spring-websocket and Browsersync use websocket so they will be grabbing the websocket port. the best way is to separate the Browsersync websocket port to a different one otherwise the spring-websocket will not work in the way as expected.

One typical error would refer to this ticket BrowserSync/browser-sync#625.

this change requires BrowserSync version 2.8.1+

both the spring-websocket and Browsersync use websocket so they will grabbing the websocket port. the best way is to separate the Browsersync websocket port to a different one otherwise the spring-websocket will not work in the way as expected.
this change requires BrowserSync version 2.8.1+
@ruddell
Copy link
Member

ruddell commented Feb 28, 2017

Confirmed it works, thanks! This was bothering me but I wasn't sure where it came from.

Can you please change it so that the comma is at the end of the target line? Also because we generate with browser-sync 2.18.7, I don't think the comment is needed

        proxy: {
            target: 'http://localhost:9060'<% if (websocket === 'spring-websocket') { %>,
            ws: true<% } %>
        }

1. remove comment as the version used in the generator matches by default;
2. move the comma to a better position at the end of line.
Copy link
Contributor Author

@jhcao23 jhcao23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-formatted the change!

@jdubois jdubois merged commit 11d2adb into jhipster:master Mar 1, 2017
@jdubois jdubois modified the milestone: 4.0.7 Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants