Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from vuex to pinia. #21978

Merged
merged 4 commits into from May 2, 2023
Merged

Switch from vuex to pinia. #21978

merged 4 commits into from May 2, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented May 1, 2023

  • pinia is now the recommended store and supports vue 2 and vue 3.
  • provide authentication status, currentUsername and currentLanguage as a reactive field globally instead of using the store at each component.
  • provide changeLanguage as function globally instead of mixed store/service methods.
  • languages is static don't need to be put into a store.
  • remove unnecessary store from tests.

Related to #12558.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added theme: dependencies Pull requests that update a dependency file theme: i18n theme: vue labels May 1, 2023
@DanielFran DanielFran merged commit cd5018d into jhipster:main May 2, 2023
48 checks passed
@github-actions github-actions bot deleted the skip_ci-pinia branch May 2, 2023 08:24
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: i18n theme: vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants