Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework LoginService and provided services #21963

Merged
merged 2 commits into from Apr 28, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Apr 28, 2023

  • provide the actual service. Providing a factory is not a good practice since the service needs to be instantiated at each use.
  • don't provide admin services at main, instantiate it on demand.
  • rework main configuration to the component setup.
  • remove the need to pass $root to openLogin, current instance should be avoided.
  • move router's not-found treatment to router/index to simplify main.

Related to #12558.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit aaf173b into jhipster:main Apr 28, 2023
28 checks passed
@github-actions github-actions bot deleted the skip_ci-vue-injects branch April 28, 2023 19:20
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants