Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vue-i18n-bridge for migration. #21935

Merged
merged 11 commits into from Apr 28, 2023
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Apr 26, 2023

  • replaces $t which is reserved at vue 3 with t$.
  • drop custom formatter. vue-i18n v9 doesn't support.
  • create a transform to convert i18n files to v9 format.

Related to #12558.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added theme: dependencies Pull requests that update a dependency file theme: vue labels Apr 26, 2023
@mshima
Copy link
Member Author

mshima commented Apr 28, 2023

@DanielFran can we merge this?
Review can be done post merged too.
It changes almost every file blocking others PRs.

@DanielFran DanielFran merged commit d65551f into jhipster:main Apr 28, 2023
28 checks passed
@github-actions github-actions bot deleted the skip_ci-vue-i18n branch April 28, 2023 14:19
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants