Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework alertService #21922

Merged
merged 2 commits into from Apr 25, 2023
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Apr 25, 2023

Providing a factory is not a good practice, the class needs to be instantiated at each use.

  • provide a singleton instead of a factory.
  • move from main to app component. At main vue instance is not available yet.
  • remove vue instance from methods parameters.
  • implement a composable useAlertService.

Related to #12558


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 0a7ea98 into jhipster:main Apr 25, 2023
28 checks passed
@github-actions github-actions bot deleted the skip_ci-vue-alert-service branch April 25, 2023 19:47
@DanielFran DanielFran added this to the 8.0.0-beta.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants