Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove unnecessary optional property" #19431

Closed
wants to merge 1 commit into from

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 15, 2022

Reverts #19427 once angular/angular#46918 has been resolved.

Related to #19373

@ertunga
Copy link
Contributor

ertunga commented Aug 15, 2022

@mshima I think we can merge this without waiting. Mentioned lines in the issue are wrapped with ngIf checks that make sure the fields are there. Even the fields can be null or undefined, because of the ngIf ?. can be removed here.

Here is an example, we can remove the question mark here.

<div *ngIf="post.blog"> <a [routerLink]="['/blog', post.blog.id, 'view']">{{ post.blog?.name }}</a> </div>

@mshima mshima closed this Aug 15, 2022
@mshima mshima deleted the revert-19427-angular-ng8107-warning branch August 15, 2022 21:24
@DanielFran DanielFran added this to the 7.9.3 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants