Add cypress as e2e tests framework #12210

avdev4j · 2020-08-06T11:16:03Z

#11961

Please make sure the below checklist is followed for Pull Requests.

All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed
Migrate or abandon entity tests

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

generators/app/index.js

mshima

I think you should not remove protractor tests and keep both while cypress is not a full replacement.

generators/app/index.js

generators/e2e/index.js

generators/client/templates/vue/.eslintignore.ejs

generators/e2e/index.js

avdev4j · 2020-08-07T15:53:13Z

I think you should not remove protractor tests and keep both while cypress is not a full replacement.

We are moving all scenario tests from Protractor to Cypress and plan to deprecate Protractor.
We could have both protractor and cypress in CI and decide to deprecate Protractor and no test it anymore.

generators/app/prompts.js

generators/client/templates/vue/tsconfig.json.ejs

generators/client/files-common.js

...ss/templates/src/test/javascript/cypress/integration/account/reset_password_page_spec.ts.ejs

.../cypress/templates/src/test/javascript/cypress/integration/account/settings_page_spec.ts.ejs

MathieuAA

My biggest issue is the naming convention used for data-cy

generators/client/templates/angular/package.json.ejs

...r/src/main/webapp/app/account/password-reset/finish/password-reset-finish.component.html.ejs

...rs/client/templates/angular/src/main/webapp/app/account/password/password.component.html.ejs

...rs/client/templates/angular/src/main/webapp/app/account/settings/settings.component.html.ejs

...t/templates/angular/src/main/webapp/app/admin/configuration/configuration.component.html.ejs

generators/client/templates/react/package.json.ejs

generators/client/templates/vue/package.json.ejs

clementdessoude

Great work, really impressive !

Just an additional general comment: One thing that is troubling me a bit is some coupling between tests, that rely on the state of another test. It is not recommended in Cypress best practices: https://docs.cypress.io/guides/references/best-practices.html#Having-tests-rely-on-the-state-of-previous-tests

...rs/client/templates/angular/src/main/webapp/app/account/register/register.component.html.ejs

generators/cypress/files.js

generators/cypress/index.js

generators/cypress/templates/cypress.json.ejs

.../templates/src/test/javascript/cypress/integration/administration/administration_spec.ts.ejs

generators/cypress/files.js

...ors/cypress/templates/src/test/javascript/cypress/integration/account/login_page_spec.ts.ejs

generators/cypress/templates/src/test/javascript/cypress/support/keycloak-oauth2.ts.ejs

...ss/templates/src/test/javascript/cypress/integration/account/reset-password-page_spec.ts.ejs

.../cypress/templates/src/test/javascript/cypress/integration/account/settings-page_spec.ts.ejs

.../templates/src/test/javascript/cypress/integration/administration/administration_spec.ts.ejs

avdev4j · 2020-08-10T18:40:09Z

Great work, really impressive !

Just an additional general comment: One thing that is troubling me a bit is some coupling between tests, that rely on the state of another test. It is not recommended in Cypress best practices: https://docs.cypress.io/guides/references/best-practices.html#Having-tests-rely-on-the-state-of-previous-tests

I agree with and that's why I reworked the register spec file. We plan to do the same with other tests, avoid tests to be dependent from others.

If you are ok @clementdessoude you could check the modifications and tell us if you think the modifications are good enough.

.../cypress/templates/src/test/javascript/cypress/integration/account/register-page_spec.ts.ejs

.../cypress/templates/src/test/javascript/cypress/integration/account/settings-page_spec.ts.ejs

.../templates/src/test/javascript/cypress/integration/administration/administration_spec.ts.ejs

test-integration/scripts/24-tests-e2e.sh

CLAassistant · 2020-08-12T10:14:19Z

All committers have signed the CLA.

avdev4j · 2020-08-13T16:31:58Z

We are waiting for #12243 to remove the draft flag. I think all things are done.

DanielFran · 2020-08-13T16:36:52Z

@avdev4j I merge the #12243, you can remove the draft :)

- fix field.js - add faker to all clients package.json if we use cypress

pascalgrimaud · 2020-08-22T16:05:11Z

@avdev4j @adilabed @nassimerrahoui :
A big advice here, to progress in this PR is to stop rebase + push force:
avdev4j force-pushed the avdev4j:add-cypress branch from a6ec7ff to a147f0b yesterday

We lost some commits:

Add oauth2 condition to commands file avdev4j/generator-jhipster#54
Refactor cypress tests. avdev4j/generator-jhipster#47
which have been merged but it's not in this PR.

We should use git fetch + git merge name/branch, so no work will be lost

Fixes to cypress entity generator.

Add tests for entity-client part

avdev4j · 2020-08-24T08:49:30Z

As the work on Cypress is more important than exepcted (even if I think we are close to finish it), we merge this PR on a new Cypress branch. Every further modifications would be done from this branch. When we'll decide, the cypress branch will be merged into the master one.

At least we need to:

fix the Cassandra/Vue build
Remove the last Protractor build from the CI

mshima

Great work everyone.
It looks great!

nassimerrahoui · 2020-08-24T12:49:03Z

We made it 🥇

avdev4j · 2020-08-24T12:50:52Z

The last but not least :
#12297

And I hope we could merge it. GG team !

DanielFran · 2020-08-24T13:09:57Z

Great. It is now just missing the update to cypress 5

nassimerrahoui · 2020-08-24T13:18:15Z

Great. It is now just missing the update to cypress 5

We forgot it. Done here jhipster#12298

avdev4j · 2020-08-25T07:44:25Z

As we struggle a bit with Cypress 5 CI builds, I suggest to merge Cypress 4+ as is and keep working aside on Cypress 5. The goal is to avoid, as much as possible, conflicts between branches.

avdev4j mentioned this pull request Aug 6, 2020

Add cypress sendilkumarn/generator-jhipster#46

Closed

4 tasks

avdev4j closed this Aug 6, 2020

avdev4j reopened this Aug 6, 2020

avdev4j commented Aug 6, 2020

View reviewed changes

generators/app/index.js Outdated Show resolved Hide resolved

mshima requested changes Aug 6, 2020

View reviewed changes

generators/app/index.js Outdated Show resolved Hide resolved

generators/app/index.js Outdated Show resolved Hide resolved

generators/e2e/index.js Outdated Show resolved Hide resolved

generators/e2e/index.js Outdated Show resolved Hide resolved

avdev4j force-pushed the add-cypress branch from c97c265 to 4d96aac Compare August 7, 2020 10:04

mshima requested changes Aug 7, 2020

View reviewed changes

generators/client/templates/vue/.eslintignore.ejs Outdated Show resolved Hide resolved

generators/client/templates/vue/.eslintignore.ejs Outdated Show resolved Hide resolved

generators/e2e/index.js Outdated Show resolved Hide resolved

generators/e2e/index.js Outdated Show resolved Hide resolved

qmonmert reviewed Aug 7, 2020

View reviewed changes

generators/app/prompts.js Outdated Show resolved Hide resolved

qmonmert reviewed Aug 7, 2020

View reviewed changes

generators/client/templates/vue/tsconfig.json.ejs Outdated Show resolved Hide resolved

mshima requested changes Aug 7, 2020

View reviewed changes

generators/client/files-common.js Outdated Show resolved Hide resolved

generators/client/files-common.js Outdated Show resolved Hide resolved

qmonmert reviewed Aug 7, 2020

View reviewed changes

...ss/templates/src/test/javascript/cypress/integration/account/reset_password_page_spec.ts.ejs Outdated Show resolved Hide resolved

qmonmert reviewed Aug 7, 2020

View reviewed changes

.../cypress/templates/src/test/javascript/cypress/integration/account/settings_page_spec.ts.ejs Outdated Show resolved Hide resolved

MathieuAA reviewed Aug 7, 2020

View reviewed changes

clementdessoude reviewed Aug 7, 2020

View reviewed changes

qmonmert reviewed Aug 10, 2020

View reviewed changes

...ss/templates/src/test/javascript/cypress/integration/account/reset-password-page_spec.ts.ejs Outdated Show resolved Hide resolved

qmonmert reviewed Aug 10, 2020

View reviewed changes

.../cypress/templates/src/test/javascript/cypress/integration/account/settings-page_spec.ts.ejs Outdated Show resolved Hide resolved

qmonmert reviewed Aug 10, 2020

View reviewed changes

.../templates/src/test/javascript/cypress/integration/administration/administration_spec.ts.ejs Outdated Show resolved Hide resolved

avdev4j force-pushed the add-cypress branch from 649898b to fc845cf Compare August 10, 2020 22:07

qmonmert reviewed Aug 11, 2020

View reviewed changes

.../cypress/templates/src/test/javascript/cypress/integration/account/register-page_spec.ts.ejs Outdated Show resolved Hide resolved

qmonmert reviewed Aug 11, 2020

View reviewed changes

.../cypress/templates/src/test/javascript/cypress/integration/account/settings-page_spec.ts.ejs Outdated Show resolved Hide resolved

qmonmert reviewed Aug 11, 2020

View reviewed changes

.../templates/src/test/javascript/cypress/integration/administration/administration_spec.ts.ejs Outdated Show resolved Hide resolved

DanielFran requested changes Aug 11, 2020

View reviewed changes

test-integration/scripts/24-tests-e2e.sh Outdated Show resolved Hide resolved

avdev4j force-pushed the add-cypress branch 3 times, most recently from b5aa926 to 67db059 Compare August 12, 2020 16:35

nassimerrahoui added 3 commits August 21, 2020 19:59

Fix generateFakeData

2d86fdb

- fix field.js - add faker to all clients package.json if we use cypress

Import faker from files.js + fixes

534966f

Fix imports in files.js

03765a2

mshima and others added 13 commits August 22, 2020 17:43

Implement entity generateFakeData for a full validated sample.

97c4673

Improvements to generateFakeData

ec12d58

Fix cypress test.

6d0df1b

Change screenshots folder

11b4a75

Store cypress failure screenshots

8ac5bd3

Fix fake user

dbb5c9d

Generate a validated full entity sample.

48ad291

Use timestamp from generateFakeData

7a97743

Scroll to top for a better screenshot

dc5f5b2

Use enum sample

e21f552

Drop faker from generated package.json

9a5ac5a

Merge pull request #1 from mshima/skip_ci_cypress

bd588e6

Fixes to cypress entity generator.

Merge pull request #55 from nassimerrahoui/add-cypress

ce15c71

Add tests for entity-client part

avdev4j changed the base branch from master to cypress August 24, 2020 08:11

merge modifications from master

776da07

avdev4j marked this pull request as ready for review August 24, 2020 08:43

avdev4j merged commit 6df18ad into jhipster:cypress Aug 24, 2020

mshima reviewed Aug 24, 2020

View reviewed changes

avdev4j deleted the add-cypress branch August 25, 2020 08:16

pascalgrimaud added this to the 7.0.0 milestone Oct 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cypress as e2e tests framework #12210

Add cypress as e2e tests framework #12210

avdev4j commented Aug 6, 2020 •

edited

mshima left a comment

avdev4j commented Aug 7, 2020 •

edited

MathieuAA left a comment

clementdessoude left a comment

avdev4j commented Aug 10, 2020 •

edited

CLAassistant commented Aug 12, 2020 •

edited

avdev4j commented Aug 13, 2020

DanielFran commented Aug 13, 2020

pascalgrimaud commented Aug 22, 2020

avdev4j commented Aug 24, 2020

mshima left a comment

nassimerrahoui commented Aug 24, 2020

avdev4j commented Aug 24, 2020

DanielFran commented Aug 24, 2020

nassimerrahoui commented Aug 24, 2020 •

edited

avdev4j commented Aug 25, 2020

Add cypress as e2e tests framework #12210

Add cypress as e2e tests framework #12210

Conversation

avdev4j commented Aug 6, 2020 • edited

mshima left a comment

Choose a reason for hiding this comment

avdev4j commented Aug 7, 2020 • edited

MathieuAA left a comment

Choose a reason for hiding this comment

clementdessoude left a comment

Choose a reason for hiding this comment

avdev4j commented Aug 10, 2020 • edited

CLAassistant commented Aug 12, 2020 • edited

avdev4j commented Aug 13, 2020

DanielFran commented Aug 13, 2020

pascalgrimaud commented Aug 22, 2020

avdev4j commented Aug 24, 2020

mshima left a comment

Choose a reason for hiding this comment

nassimerrahoui commented Aug 24, 2020

avdev4j commented Aug 24, 2020

DanielFran commented Aug 24, 2020

nassimerrahoui commented Aug 24, 2020 • edited

avdev4j commented Aug 25, 2020

avdev4j commented Aug 6, 2020 •

edited

avdev4j commented Aug 7, 2020 •

edited

avdev4j commented Aug 10, 2020 •

edited

CLAassistant commented Aug 12, 2020 •

edited

nassimerrahoui commented Aug 24, 2020 •

edited