Skip to content

Commit

Permalink
aqr: fix mypy warnings
Browse files Browse the repository at this point in the history
Uvicorn is very close to implementing typing at which point we can
upgrade and remove the ignore.
encode/uvicorn#998

Signed-off-by: Joshua Hesketh <jhesketh@suse.com>
  • Loading branch information
jhesketh committed Jan 18, 2022
1 parent a1452b1 commit 3319080
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
5 changes: 2 additions & 3 deletions src/aquarium.py
Expand Up @@ -26,6 +26,8 @@
from fastapi import FastAPI
from fastapi.logger import logger as fastapi_logger
from fastapi.staticfiles import StaticFiles
from uvicorn import Config as UvicornConfig # type: ignore
from uvicorn import Server as UvicornServer # type: ignore

from gravel.api import auth, deploy, devices, local, nodes, orch, status, users
from gravel.cephadm.cephadm import Cephadm
Expand All @@ -47,9 +49,6 @@

logger: logging.Logger = fastapi_logger

from uvicorn.config import Config as UvicornConfig
from uvicorn.server import Server as UvicornServer

faulthandler.register(signal.SIGUSR1.value)

HANDLED_SIGNALS = (
Expand Down
7 changes: 4 additions & 3 deletions src/gravel/tests/conftest.py
Expand Up @@ -355,9 +355,10 @@ def app(caplog: Any, aquarium_startup: FastAPI, aquarium_shutdown: FastAPI):
caplog.set_level(logging.DEBUG)
import aquarium

return aquarium.aquarium_factory(
startup_method=aquarium_startup, shutdown_method=aquarium_shutdown
)
# TODO(jhesketh): FIX ME!
# return aquarium.aquarium_factory(
# startup_method=aquarium_startup, shutdown_method=aquarium_shutdown
# )


@pytest.fixture
Expand Down

0 comments on commit 3319080

Please sign in to comment.