Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Maintenance #1167

Merged
merged 2 commits into from Jan 1, 2024
Merged

CI Maintenance #1167

merged 2 commits into from Jan 1, 2024

Conversation

syoon2
Copy link

@syoon2 syoon2 commented Dec 18, 2023

This PR adds maintenance patches to GitHub Action workflows. This includes:


- Bump up action versions
- Use builtin caches in actions
@syoon2
Copy link
Author

syoon2 commented Dec 27, 2023

Range-diff:

-:  ---------- > 1:  b92c214e1c Fix CRLF/LF Consistency (#1166)
-:  ---------- > 2:  f1c32a530a Credits for last merge.
-:  ---------- > 3:  e625da9351 JUnit 5 Migration (#1163)
-:  ---------- > 4:  9c98ae8a2d Credits for last merge.
1:  a0f8b7b282 = 5:  d9bc9d2d78 Update GitHub Action workflows
2:  a8171ef173 = 6:  d3d9b3ec87 Setup Dependabot

@jsichi Mind if I ask for your review?

@jsichi
Copy link
Member

jsichi commented Jan 1, 2024

Thanks, I will just go ahead and merge this and see what happens, since it seems like CI hasn't been running on master for a while anyway, only on PR branches?

@jsichi jsichi merged commit e8c9ddb into jgrapht:master Jan 1, 2024
1 check passed
@jsichi
Copy link
Member

jsichi commented Jan 1, 2024

(Correction, CI has been running on master correctly; my mistake.)

@jsichi
Copy link
Member

jsichi commented Jan 1, 2024

After merging to master, CI is now failing with "Error: Dependencies lock file is not found in /home/runner/work/jgrapht/jgrapht. Supported file patterns: package-lock.json,npm-shrinkwrap.json,yarn.lock"

See the log here:

https://github.com/jgrapht/jgrapht/actions/runs/7374477613/job/20064905918

@syoon2 syoon2 deleted the gha-update branch January 2, 2024 00:14
@syoon2
Copy link
Author

syoon2 commented Jan 2, 2024

Hmm, ouch. Will submit a patch for the regression in the next hour or two.

Edit: See #1171

@syoon2 syoon2 mentioned this pull request Jan 2, 2024
7 tasks
@syoon2
Copy link
Author

syoon2 commented Jan 2, 2024

@jsichi A side note: Dependabot needs to be manually enabled (because Dependabot is disabled by default on forked repositories) in https://github.com/jgrapht/jgrapht/network/updates for it to automatically create dependency update PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants