Resolve vulnerabilities from npm audit #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran npm audit fix and followed prompts to resolve vulnerabilities. Results: - Major update to grunt version from 0.4.1 to 1.0.3 - Minor update to jshint from 2.8.0 to 2.9.6 - Major update to mocha from 2.3.4 to 5.2.0
|
@jgable no rush on this 😄 , just wondering if this is still being maintained. There's only a few repositories I use that leverage |
|
Closing due to repo inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all the work on this awesome package!
After trying to resolve vulnerabilities in my local project using
grunt-phplint, I believe that this package needs to be updated. I may not have done this correctly, so I'd appreciate some guidance as I understand there could be significant breaking changes.I ran npm audit fix and followed prompts to resolve vulnerabilities.
Results:
After these updates:
gruntresulted in success message of 3 files php linted for both tasks.npm testresulted in 1/1 passing tests.Would appreciate any feedback. I see this PR #30 was closed and couldn't find an explanation for why.