Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for the creation of a Violation Report #933

Merged
merged 52 commits into from May 9, 2024

Conversation

Felioh
Copy link
Contributor

@Felioh Felioh commented Apr 3, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Creating a ViolationReport fails du to XRay not being able to parse the request, as the specification varies from the implementation in this client: https://jfrog.com/help/r/xray-rest-apis/generate-violations-report
This fixes that.

Copy link
Contributor

github-actions bot commented Apr 3, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Felioh
Copy link
Contributor Author

Felioh commented Apr 3, 2024

I have read the CLA Document and I hereby sign the CLA

@Felioh Felioh marked this pull request as ready for review April 3, 2024 11:21
@yahavi yahavi requested a review from attiasas May 6, 2024 06:32
@yahavi yahavi added bug Something isn't working safe to test Approve running integration tests on a pull request labels May 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 6, 2024
@attiasas attiasas changed the base branch from master to dev May 6, 2024 06:52
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 6, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 6, 2024
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Felioh!

@yahavi yahavi merged commit 81215f0 into jfrog:dev May 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants