New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for the creation of a Violation Report #933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/analysis.yml # go.mod # go.sum # utils/utils.go # xray/services/scan.go # xray/services/scan_test.go
# Conflicts: # utils/utils.go
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
yahavi
added
bug
Something isn't working
safe to test
Approve running integration tests on a pull request
labels
May 6, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 6, 2024
attiasas
added
the
safe to test
Approve running integration tests on a pull request
label
May 6, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
May 6, 2024
yahavi
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Felioh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a ViolationReport fails du to XRay not being able to parse the request, as the specification varies from the implementation in this client: https://jfrog.com/help/r/xray-rest-apis/generate-violations-report
This fixes that.