Automatically create GitHub Release #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A suggestion from online was to additionally trigger publishing to pypi. https://x.com/ljharb/status/1713294633676239275 |
|
I added steps to publish to PyPI. I also realized that the GitHub release action I was using doesn't support publishing the release, so I refactored to use a different one. Finally, I added a step to attach the builds to the release. I'm not sure how to QA this aside from merging and going YOLO. Might go and do that? Will probably be a mess. |
jfhbrook
commented
Nov 23, 2023
jfhbrook
commented
Nov 23, 2023
jfhbrook
commented
Nov 23, 2023
.github/workflows/release.yaml
Outdated
| echo "python_version=[${VERSION}]" > "${GITHUB_OUTPUT}" | ||
| # See: https://stackoverflow.com/questions/58177786/get-the-current-pushed-tag-in-github-actions | ||
| - name: Get release version | ||
| run: echo "release_version=$(GITHUB_REF#refs/*/}" >> "${GITHUB_OUTPUT}" |
There was a problem hiding this comment.
I could also grab this from pyproject.toml - it's a matter of what I want to be the source of truth.
jfhbrook
commented
Nov 23, 2023
| on: | ||
| push: | ||
| tags: | ||
| - 'v*' |
There was a problem hiding this comment.
This means releases are now tagged vx.y.z instead of x.y.z. I'm OK with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #129. I haven't reviewed or tested it, but I think this would be pretty close to working.
My intent is to wait until I do the next pyee release, then self-review and decide if I like it or not.