Upgrade mime to v2 #240
Merged
Upgrade mime to v2 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 74.86% 75.04% +0.18%
==========================================
Files 9 10 +1
Lines 541 553 +12
Branches 125 127 +2
==========================================
+ Hits 405 415 +10
- Misses 47 49 +2
Partials 89 89
Continue to review full report at Codecov.
|
This was referenced Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dusted off the PR from mathias, fixed a bunch of broken tests, wrapped the mime module and added the capability to override the mime lookup code.
Also addresses and cherry-picks from #223 since that issue was closely related.
I feel pretty good about this!