Contains a workaround for the capitalized configuration issue (celery…

…#6385) * Contains a workaround for the capitalized configuration issue * Update celery/apps/worker.py Co-authored-by: Omer Katz <omer.drow@gmail.com> * Update celery/apps/worker.py Co-authored-by: Omer Katz <omer.drow@gmail.com> Co-authored-by: Omer Katz <omer.drow@gmail.com>
jeyrce · Aug 25, 2021 · a4e7efe · a4e7efe
1 parent 93732e1
commit a4e7efe
Showing 1 changed file with 19 additions and 6 deletions.
diff --git a/celery/apps/worker.py b/celery/apps/worker.py
@@ -141,12 +141,25 @@ def on_start(self):
             app.log.redirect_stdouts(self.redirect_stdouts_level)
 
         # TODO: Remove the following code in Celery 6.0
-        if app.conf.maybe_warn_deprecated_settings():
-            logger.warning(
-                "Please run `celery upgrade settings path/to/settings.py` "
-                "to avoid these warnings and to allow a smoother upgrade "
-                "to Celery 6.0."
-            )
+        # This qualifies as a hack for issue #6366.
+        # a hack via app.__reduce_keys__(), but that may not work properly in
+        # all cases
+        warn_deprecated = True
+        config_source = app._config_source
+        if isinstance(config_source, str):
+            # Don't raise the warning when the settings originate from
+            # django.conf:settings
+            warn_deprecated = config_source.lower() not in [
+                'django.conf:settings',
+            ]
+
+        if warn_deprecated:
+            if app.conf.maybe_warn_deprecated_settings():
+                logger.warning(
+                    "Please run `celery upgrade settings path/to/settings.py` "
+                    "to avoid these warnings and to allow a smoother upgrade "
+                    "to Celery 6.0."
+                )
 
     def emit_banner(self):
         # Dump configuration to screen so we have some basic information