Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9285 use possibly wrapped response for redirection #9286

Merged
merged 1 commit into from Feb 4, 2023

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Feb 2, 2023

Fixes #9285:

  • Use the servlet response sendRedirect method.
  • Always close the connection if there is content.

Signed-off-by: Greg Wilkins gregw@webtide.com

Use the servlet response sendRedirect method.
Always close the connection if there is content.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw requested review from lorban and sbordet February 2, 2023 01:20
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this feels like this is lacking a test.

@gregw gregw changed the title Fix #9285 use possibly wrapper response for redirection Fix #9285 use possibly wrapped response for redirection Feb 4, 2023
@gregw gregw merged commit 8bf7c9c into jetty-10.0.x Feb 4, 2023
@gregw gregw deleted the jetty-10-9285-wrapped-redirect branch February 4, 2023 22:18
gregpoulos pushed a commit to gregpoulos/jetty.project that referenced this pull request Feb 6, 2023
…x-documentation-operations-logging

* upstream/jetty-12.0.x: (42 commits)
  fixed style
  cleanup TODOs for decoration
  Issue jetty#9300 - Rename RetainableByteBufferPool to ByteBufferPool
  Removed TODOs that will not be done.
  Rename Handler Nested & Collection (jetty#9305)
  fix surefire jpms configuration
  fix merge
  fix merge
  Bump maven.surefire.plugin.version from 3.0.0-M5 to 3.0.0-M8 (jetty#9255)
  Rename RetainableByteBufferPool to ByteBufferPool
  Fixed merge
  Fix jetty#9285 use possibly wrapper response for redirection (jetty#9286)
  Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies (quic) (jetty#9307)
  Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies (fcgi) (jetty#9306)
  Jetty 10 - Configurable Unsafe Host Header (jetty#9283)
  Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies. (jetty#9296)
  Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies. (jetty#9299)
  fix dependency
  add used dependency
  this dependency is used in test scope
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContextHandler sends redirect on BaseResponse instead of Wrapped Response object from Handler chain
2 participants