Fixes #8913 - Review Jetty XML syntax to allow calling JDK methods #8915
+187
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now <Call>, <Get> and <Set> elements can use the "class" attribute to specify the exact class to perform method lookup. Improved support for <Property>, <SystemProperty> and <Env> so that attribute "name" is now optional (as specified in the DTD), and a "deprecated" attribute may be present instead. This is necessary to terminally deprecate properties that have no replacement. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
reviewed
Nov 18, 2022
joakime
requested changes
Nov 18, 2022
jetty-xml/src/main/java/org/eclipse/jetty/xml/XmlConfiguration.java
Outdated
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/xml/xml-syntax.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/xml/xml-syntax.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/xml/xml-syntax.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/xml/xml-syntax.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now , and elements can use the "class" attribute to specify the exact class to perform method lookup.
Improved support for , and so that attribute "name" is now optional (as specified in the DTD), and a "deprecated" attribute may be present instead.
This is necessary to terminally deprecate properties that have no replacement.
Signed-off-by: Simone Bordet simone.bordet@gmail.com