Issue #8578 - getRequestURL can append "null" if getRequestURI is unspecified in an authority-form request-target
#8579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URI when working with CONNECT method Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added
Bug
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
requested changes
Sep 10, 2022
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet
approved these changes
Sep 12, 2022
joakime
changed the title
getRequestURL can append "null" if getRequestURI is unspecified (like with CONNECT method)
joakime
changed the title
getRequestURL can append "null" if getRequestURI is unspecified (like with CONNECT method)getRequestURL can append "null" if getRequestURI is unspecified in an authority-form request-target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with CONNECT headers, the old implementation of
HttpURI.getPath()would return the authority component.The changes in #8014 broke this backward compatibility behavior, causing unintended behaviors on
HttpServletRequest.getRequestURL()andHttpServletRequest.getRequestURI().Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com