Rework static exceptions in ContentProducer #8135
Conversation
lorban
force-pushed
the
jetty-10.0.x-ContentProducer-static-exception
branch
2 times, most recently
from
6baf0c1
to
5edfef1
Compare
jetty-server/src/main/java/org/eclipse/jetty/server/AsyncContentProducer.java
Outdated
Show resolved
Hide resolved
lorban
added
Bug
There was a problem hiding this comment.
Do we need to make so many changes now that you've discovered the constructor that allows us to avoid suppressed exceptions for static sentinel Throwables.
Perhaps it is better for use to create a utility StaticThrowable class that has no stack trace and doesn't keep suppressed exceptions. We can then use that as the base for our existing static exceptions rather than replacing them.
|
|
||
| public UnconsumedContentException() | ||
| { | ||
| super("Unconsumed content", null, false, LOG.isDebugEnabled()); |
There was a problem hiding this comment.
I think this constructor is key!
Seeing that this constructor allows us to disable suppressed exceptions, there is no real reason for us to avoid static Throwables used as sentinels.
I'm not keen on using the LOG to hide stack traces. I think if it is worth creating an exception of the fly, it is worth generating a stack trace. I think we should avoid stack traces only for static sentinel Throwables.
@lachlan-roberts can you review your recent change in light of this constructor.
There was a problem hiding this comment.
I agree. While this code might be worth some refactorings, that's clearly outside the scope of the original issue which is just to avoid leaking stack traces in static exceptions.
I'm going to revert all these changes, introduce a new StaticException and keep the changes to a minimum.
…les. Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
jetty-10.0.x-ContentProducer-static-exception
branch
from
ac2c862
to
e175625
Compare
lorban
changed the title
|
Changes combined with #8155 |
As this is a potential memory leak if
Throwable.addSuppressed()is ever called on the static exception, or on the exception contained in the staticErrorContent.