Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #7975 - ForwardedRequestCustomizer should clear old MethodHandles when renaming headers #8102

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jun 2, 2022

  • Adding test case to prove report
  • Fixing updateHandles() to clear the stored handles list.

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

…les when renaming headers.

* Adding test case to prove report
* Fixing updateHandles() to clear the stored handles list.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime self-assigned this Jun 2, 2022
@joakime joakime added the Bug For general bugs on Jetty side label Jun 2, 2022
@joakime joakime added this to In progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 via automation Jun 2, 2022
@joakime joakime linked an issue Jun 2, 2022 that may be closed by this pull request
@joakime joakime moved this from In progress to Review in progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Jun 2, 2022
@joakime joakime requested a review from sbordet June 2, 2022 11:57
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from Review in progress to Reviewer approved Jun 2, 2022
@joakime joakime merged commit 944ce63 into jetty-10.0.x Jun 2, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from Reviewer approved to Done Jun 2, 2022
@joakime joakime deleted the fix/jetty-10.0.x-forwarded-request-customizer-different-headers branch June 2, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ForwardedRequestCustomizer setters do not clear existing handlers
2 participants