Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7935 - Review HTTP/2 error handling #7938

Merged
merged 2 commits into from May 11, 2022
Merged

Fixes #7935 - Review HTTP/2 error handling #7938

merged 2 commits into from May 11, 2022

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Apr 29, 2022

Now returning error handling code as a Runnable.

Signed-off-by: Simone Bordet simone.bordet@gmail.com

@sbordet
Fixes #7935 - Review HTTP/2 error handling
f78f92e 
Now returning error handling code as a Runnable.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested review from gregw and lorban April 29, 2022 19:48
@sbordet sbordet linked an issue Apr 29, 2022 that may be closed by this pull request
Review HTTP/2 error handling (CVE-2022-2048) #7935
Closed
@sbordet
Fixes #7935 - Review HTTP/2 error handling
569be44 
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested a review from joakime May 1, 2022 07:00
gregw
gregw approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm re running the CI to see if the failure was a flake.
Other than that... LGTM

@joakime joakime merged commit b705091 into jetty-10.0.x May 11, 2022
@joakime joakime deleted the jetty-10.0.x-7935-http2-error-handling branch May 11, 2022 15:28
joakime pushed a commit that referenced this pull request May 11, 2022
@sbordet @joakime
Fixes #7935 - Review HTTP/2 error handling (#7938)
af828e7 
Now returning error handling code as a Runnable.
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this pull request May 11, 2022
Merged
joakime added a commit that referenced this pull request May 11, 2022
@joakime @sbordet
Fixes #7935 - Review HTTP/2 error handling (#7938) (#7978)
be912d4 
Now returning error handling code as a Runnable.
Updates after review.

Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this pull request Oct 6, 2022
Closed
51 tasks
@sbordet
Copy link
Contributor Author

sbordet commented Oct 10, 2022

Merged to jetty-12.0.x on 11 May 2022, commit b705091.
Relevant changes have been moved from Jetty 11's HttpChannelOverHTTP2 to Jetty 12's HttpStreamOverHTTP2.
Similarly for HttpStreamOverHTTP3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime joakime approved these changes

@lorban lorban lorban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review HTTP/2 error handling (CVE-2022-2048)
4 participants
@sbordet @gregw @joakime @lorban