Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 10 7918 root pathspec #7920

Merged
merged 4 commits into from Apr 26, 2022
Merged

Jetty 10 7918 root pathspec #7920

merged 4 commits into from Apr 26, 2022

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Apr 26, 2022

In addition to cherry-picking asPathSpec fix from 9, this PR makes asPathSpec extensible in ConstraintSecurityHandler in the same way it is now extensible in ServletHandler

Handle root pathspec in PathMappings.asPathSpec

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw requested review from joakime and lorban April 26, 2022 08:38
cleaner logic

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw requested a review from lorban April 26, 2022 12:15
@gregw gregw merged commit e12d5d5 into jetty-10.0.x Apr 26, 2022
@gregw gregw deleted the jetty-10-7918-root-pathspec branch April 26, 2022 17:04
gregw added a commit that referenced this pull request Apr 26, 2022
Fix #7918 Root path spec
Handle root pathspec in PathMappings.asPathSpec
Introduce protected asPathSpec to allow for extensibility

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw linked an issue Apr 26, 2022 that may be closed by this pull request
@gregw gregw added this to In progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 via automation Apr 26, 2022
@gregw gregw moved this from In progress to Done in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

PathMappings.asPathSpec does not allow root ServletPathSpec
2 participants