#7880 retain resource service configuration #7881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faultServlet unless overridden by an InitParameter.
markslater
force-pushed
the
#7880_retain_resource_service_configuration
branch
from
80fa890
to
708553d
Compare
joakime
previously approved these changes
Apr 14, 2022
joakime
moved this from In progress
to Review in progress
in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
|
You have an NPE causing a 500 error in See https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-7881/3/tests |
|
Uh, that was careless of me. I've pushed a fix. |
Yes |
joakime
approved these changes
Apr 20, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Review in progress
to Reviewer approved
Apr 20, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶
automation
moved this from Reviewer approved
to Done
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method for getting
Booleaninit parameters that returnsnullif not set.Rewrote method for getting
booleanor default init parameters to useBooleaninit parameters method.Used
Booleaninit parameter to identify when neitherprecompressednorgzipinit parameters have been set, and fall back to existing precompression formats from_resourceService.