Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7754 - Allow JETTY_SYS_PROPS to be configured by /etc/default/ #7819

Merged

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Apr 1, 2022

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked an issue Apr 1, 2022 that may be closed by this pull request
@joakime joakime self-assigned this Apr 1, 2022
@joakime joakime added this to In progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 via automation Apr 1, 2022
@joakime
Copy link
Contributor Author

joakime commented Apr 5, 2022

Wow, the JDK-17 build core dumped ...

[INFO] --- spotbugs-maven-plugin:4.6.0.0:spotbugs (spotbugs) @ jetty-util ---
[INFO] Fork Value is false
     [java] JVM args ignored when same JVM is used.
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f48e9e10293, pid=3550517, tid=3551682
#
# JRE version: OpenJDK Runtime Environment Temurin-17.0.2+8 (17.0.2+8) (build 17.0.2+8)
# Java VM: OpenJDK 64-Bit Server VM Temurin-17.0.2+8 (17.0.2+8, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
# Problematic frame:
# V  [libjvm.so+0xe2f293]  PhaseIdealLoop::spinup(Node*, Node*, Node*, Node*, Node*, small_cache*) [clone .part.42]+0x53
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport %p %s %c %d %P %E" (or dumping to /home/jenkins/agent/workspace/jetty.project_PR-7819/core.3550517)
#
# An error report file with more information is saved as:
# /home/jenkins/agent/workspace/jetty.project_PR-7819/hs_err_pid3550517.log
#
# Compiler replay data is saved as:
# /home/jenkins/agent/workspace/jetty.project_PR-7819/replay_pid3550517.log
#
# If you would like to submit a bug report, please visit:
#   https://github.com/adoptium/adoptium-support/issues
#

Aborted (core dumped)

@joakime joakime marked this pull request as ready for review April 7, 2022 10:53
@joakime joakime requested a review from gregw April 7, 2022 10:53
@joakime joakime added this to the 10.0.x milestone Apr 7, 2022
@joakime joakime moved this from In progress to Review in progress in Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 Apr 7, 2022
@joakime joakime requested review from gregw and removed request for gregw May 16, 2022 20:39
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from Review in progress to Reviewer approved May 25, 2022
@joakime joakime merged commit 3fe0d5e into jetty-10.0.x May 26, 2022
Jetty 10.0.10/11.0.10 - 🧊 FROZEN 🥶 automation moved this from Reviewer approved to Done May 26, 2022
@joakime joakime deleted the fix/7754-jettysh-cannot-configure-java_sys_props branch May 26, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

jetty.sh ignores JAVA_OPTIONS environment variable
2 participants