Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7635 - implement maxBlockedStreams logic in QpackDecoder #7660

Merged

Conversation

lachlan-roberts
Copy link
Contributor

Closes #7635

Add verification that the max blocked streams is not exceeded inside the QpackDecoder.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@joakime joakime added this to the 10.0.x milestone Apr 7, 2022
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Copy link
Contributor Author

@sbordet I have copied over some of the same changes from #7802 to help with testing.

sbordet
sbordet previously approved these changes May 13, 2022
@lachlan-roberts lachlan-roberts merged commit 7557ae3 into jetty-10.0.x May 16, 2022
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-7635-QpackDecoderMaxBlockedStreams branch May 16, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QPACK decoder should fail connection if the encoder blocks more than SETTINGS_QPACK_BLOCKED_STREAMS
3 participants