Improve #4275 ambiguous URIs #6939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A URI like `/foo/%2e%2e;/bar` should be ambiguous both because of the encoded dots and because of the parameters. This means that the default setting of jetty-9 is a bit more secure as this path is considered ambiguous if either Violation.SEGMENT or Violation.PARAM is set. Signed-off-by: Greg Wilkins <gregw@webtide.com>
lachlan-roberts
requested changes
Sep 29, 2021
|
@gregw there are test failures. |
Signed-off-by: Greg Wilkins <gregw@webtide.com>
lachlan-roberts
previously approved these changes
Sep 29, 2021
Jetty 9.4.45 - FROZEN
automation
moved this from Review in progress
to Reviewer approved
Sep 29, 2021
Signed-off-by: Greg Wilkins <gregw@webtide.com>
Jetty 9.4.45 - FROZEN
automation
moved this from Reviewer approved
to Review in progress
Sep 30, 2021
|
@lachlan-roberts can you re-review.... I've been a little evil and snuck in a few extra fixes replacing == with equals |
lachlan-roberts
approved these changes
Sep 30, 2021
Jetty 9.4.45 - FROZEN
automation
moved this from Review in progress
to Reviewer approved
Sep 30, 2021
lachlan-roberts
added this to In progress
in Jetty 10.0.8/11.0.8 - FROZEN
via automation
lachlan-roberts
added a commit
that referenced
this pull request
Oct 12, 2021
* Improve #4275 ambiguous URIs A URI like `/foo/%2e%2e;/bar` should be ambiguous both because of the encoded dots and because of the parameters. This means that the default setting of jetty-9 is a bit more secure as this path is considered ambiguous if either Violation.SEGMENT or Violation.PARAM is set. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4275
A URI like
/foo/%2e%2e;/barshould be ambiguous both because of the encoded dots and because of the parameters. This means that the default setting of jetty-9 is a bit more secure as this path is considered ambiguous if either Violation.SEGMENT or Violation.PARAM is set.Signed-off-by: Greg Wilkins gregw@webtide.com