Changed order of entries in module-info.java to be canonical #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbordet this touched a lot of files and there is a distinct possibility that I made a mistake somewhere, despite checking everything several times. |
sbordet
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the canonical order of the elements inside the module-info.java file in the OpenJDK/src is always the same:
`module some.module.name {
requires ...
requires transitive ...
exports ...
exports ... to
...
opens ... to
...
uses ...
provides ... with
...
}`
The order in our module-info.java files were a bit muddled, with requires sometimes appearing near the end.
Furthermore, the entries are usually alphabetically sorted.
(There is one case in the OpenJDK where requires transitive is out of order, but that was because someone changed it and didn't reorder it. I've sent a pull-request there too, but it's so insignificant I almost doubt it will be accepted.)
See also
https://docs.oracle.com/javase/specs/jls/se17/html/jls-7.html#jls-ModuleDirective