Fix #6870 Encode control characters #6874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce #6870 Rewritten Balancer Signed-off-by: Greg Wilkins <gregw@webtide.com>
|
I've pushed a reproduction in a unit test for the BalancerServlet, although ultimately I think this should be a test/fix in jetty-http and/or jetty-rewrite |
Fix #6870 URIUtil.encodePath encodes control characters Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw
changed the title
sbordet
requested changes
Sep 20, 2021
jetty-proxy/src/test/java/org/eclipse/jetty/proxy/BalancerServletTest.java
Outdated
Show resolved
Hide resolved
Encode all control characters Signed-off-by: Greg Wilkins <gregw@webtide.com>
Signed-off-by: Greg Wilkins <gregw@webtide.com>
joakime
approved these changes
Sep 21, 2021
sbordet
approved these changes
Sep 21, 2021
gregw
added a commit
that referenced
this pull request
Sep 23, 2021
gregw
added a commit
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce #6870 Rewritten Balancer
Signed-off-by: Greg Wilkins gregw@webtide.com