Fix #6868 Fix copy constructors #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed copy constructors found by static code analysis Signed-off-by: Greg Wilkins <gregw@webtide.com>
lachlan-roberts
previously approved these changes
Sep 20, 2021
| _patterns.exclude(matcher._patterns.getExcluded().toArray(new Entry[0])); | ||
| _locations.include(matcher._locations.getIncluded().toArray(new Entry[0])); | ||
| _locations.exclude(matcher._locations.getExcluded().toArray(new Entry[0])); | ||
| } |
There was a problem hiding this comment.
The ClassMatcher.add() method actually sets _locations and _patterns anyway.
But I think this is equivalent behaviour, unless someone has a subclass of ClassMatcher to override add(Entry).
There was a problem hiding this comment.
yeah, it was more to keep the static analysis quiet so we can get a clean test.
Hmmm but your point about add is valid. I'll see if I can suppress the analysis.
update from review Signed-off-by: Greg Wilkins <gregw@webtide.com>
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Reviewer approved
to Review in progress
Sep 20, 2021
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Review in progress
to Reviewer approved
Sep 20, 2021
lachlan-roberts
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6868 copy constructors found by static code analysis
Signed-off-by: Greg Wilkins gregw@webtide.com