Issue #3514 interpolation of mod files to avoid hardcoding version in mod files

[olamy]

to prevent issues with the current usage of ${} in mod files. Interpolation of values from pom will be based on the delimiter @....@ such @log4j2.version@

Signed-off-by: Olivier Lamy oliver.lamy@gmail.com

[janbartel]

Need to also do: memcached and mongo.

[janbartel]

Is this correct? Why is this ${jolokia.version} here, but @jolokia.version@ on line 22?

[olamy]

as explained in the PR description ;)

to prevent issues with the current usage of ${} in mod files. 
Interpolation of values from pom will be based on the delimiter @....@ such @log4j2.version@

this file have the following section

[ini]
jolokia.version?=@jolokia.version@

this section will be transformed to

[ini]
jolokia.version?=3.5.4 (or whatever the value coming from the pom)

The idea is to keep the the option to run jetty using such parameter to test new jolokia version

java -jar start.jar jolokia.version=6.4.4

[joakime]

To me the use of @blah@ is processed by the resource plugin filtering resulting in a "hardcoded" value at build time.
The use of ${blah} is left alone.

[olamy]

yes I didn't want to touch anything about ${bla} because already used in mod files.

[janbartel]

I don't think this difference is documented anywhere? So you're saying that if the substitution happens at runtime, like when the start mechanism processes the .mod/.ini file then you use ${var}, but if it happens at build time, then you use @var@??? That's a pretty subtle difference, think that needs a good explanation somewhere.

[joakime]

@janbartel The @var@ syntax is standard Maven Resource handling with filtering.

• The @var@ syntax is compile time expanded during the compile/package steps.
• The ${var} syntax is runtime expanded, and in the specific cases on this PR, only by jetty-start.

[joakime]

Btw, we use the same @var@ syntax in our jetty-maven-plugin/src/it/* and jetty-jspc-maven-plugin/src/it/* test cases.
Also, the @var@ syntax is the most common form of maven resource filtering (during the various resource phases of the build).

[olamy]

memcached and mongo done

[joakime]

2 more mod files need conversion.

./demos/demo-jndi-webapp/src/main/config/modules/demo-jndi.mod:maven://org.eclipse.jetty.orbit/javax.mail.glassfish/1.4.1.v201005082020/jar|lib/ext/javax.mail.glassfish-1.4.1.v201005082020.jar
./demos/demo-jndi-webapp/src/main/config/modules/demo-jndi.mod:maven://jakarta.transaction/jakarta.transaction-api/1.3.2/jar|lib/ext/jakarta.transaction-api-1.3.2.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://org.jminix/jminix/1.1.0|lib/jminix/jminix-1.1.0.jar
./jetty-home/src/main/resources/modules/jminix.mod:https://maven.restlet.talend.com/org/restlet/org.restlet/1.1.5/org.restlet-1.1.5.jar|lib/jminix/org.restlet-1.1.5.jar
./jetty-home/src/main/resources/modules/jminix.mod:https://maven.restlet.talend.com/org/restlet/org.restlet.ext.velocity/1.1.5/org.restlet.ext.velocity-1.1.5.jar|lib/jminix/org.restlet.ext.velocity-1.1.5.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://org.apache.velocity/velocity/1.5|lib/jminix/velocity-1.5.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://oro/oro/2.0.8|lib/jminix/oro-2.0.8.jar
./jetty-home/src/main/resources/modules/jminix.mod:https://maven.restlet.talend.com/com/noelios/restlet/com.noelios.restlet/1.1.5/com.noelios.restlet-1.1.5.jar|lib/jminix/com.noelios.restlet-1.1.5.jar
./jetty-home/src/main/resources/modules/jminix.mod:https://maven.restlet.talend.com/com/noelios/restlet/com.noelios.restlet.ext.servlet/1.1.5/com.noelios.restlet.ext.servlet-1.1.5.jar|lib/jminix/com.noelios.restlet.ext.servlet-1.1.5.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://net.sf.json-lib/json-lib/2.2.3/jar/jdk15|lib/jminix/json-lib-2.2.3-jdk15.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://commons-lang/commons-lang/2.4|lib/jminix/commons-lang-2.4.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://commons-beanutils/commons-beanutils/1.7.0|lib/jminix/commons-beanutils-1.7.0.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://commons-collections/commons-collections/3.2|lib/jminix/commons-collections-3.2.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://net.sf.ezmorph/ezmorph/1.0.6|lib/jminix/ezmorph-1.0.6.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://org.jgroups/jgroups/2.12.1.3.Final|lib/jminix/jgroups-2.12.1.3.Final.jar
./jetty-home/src/main/resources/modules/jminix.mod:maven://org.jasypt/jasypt/1.8|lib/jminix/jasypt-1.8.jar

[olamy]

@joakime to be honest I would even prefer remove jminix as it's not really maintained and hawtio is providing the same features (and it's maintained)

[joakime]

I'm happy with this as it sits.

I'll go ahead and merge up the conflicts from the infinispan PR into this.

[olamy]

demo-jndi.mod fixed.
not sure we want to fix jminix but deprecate/remove it. (see #6879)

Change already applied, Old review no longer relevant