Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6752 DefaultSessionCache more extensible using ConcurrentMap #6753

Merged
merged 1 commit into from Sep 10, 2021
Merged

Issue #6752 DefaultSessionCache more extensible using ConcurrentMap #6753

merged 1 commit into from Sep 10, 2021

Commits on Sep 9, 2021

  1. Issue #6752 DefaultSessionCache more extensible using ConcurrentMap 

    DefaultSessionCache is designed to be extended, by virtue of its protected session map. Subclasses can set their own map instance instead. However the session map is specified as ConcurrentHashMap, when it only needs to be ConcurrentMap.
Changed data type to ConcurrentMap to allow for wider options for subclasses, such as those wanted to use Caffeine's asMap() method which returns ConcurrentMap.
Although changing to even more relaxed Map would work, that does not provide as much clarity that the map will be used concurrently - therefore used ConcurrentMap instead.

Signed-off-by: Padraic Renaghan <padraic@renaghan.com>
    @prenagha
    prenagha committed Sep 9, 2021
    Copy the full SHA
    159f042 View commit details
    Browse the repository at this point in the history