Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6072 - backport of minimum fix for jetty-9.3.x #6734

Merged
merged 3 commits into from Sep 20, 2021
Merged

Issue #6072 - backport of minimum fix for jetty-9.3.x #6734

merged 3 commits into from Sep 20, 2021

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Sep 8, 2021 •
edited

Backport of #6072 (Large TLS Record Fix) to branch jetty-9.3.x

Co-authored-by: Olivier Lamy oliver.lamy@gmail.com
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

@olamy @joakime
Issue #6072 - backport of minimum fix for jetty-9.3.x
ecc0bee 
Co-authored-by: Olivier Lamy <oliver.lamy@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement End-of-Life release labels Sep 8, 2021
@joakime joakime self-assigned this Sep 8, 2021
@joakime joakime added this to In progress in Jetty 9.3.30 FROZEN via automation Sep 8, 2021
@joakime joakime mentioned this pull request Sep 8, 2021
Closed
gregw
gregw requested changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not mind walking through this one with @sbordet

jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslConnection.java Show resolved Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslConnection.java Show resolved Hide resolved
@joakime
Issue #6072 - changes from review
9d7160d 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime requested a review from gregw September 11, 2021 09:22
@joakime
Copy link
Contributor Author

joakime commented Sep 11, 2021

@gregw i had a review from @sbordet and made the last set of changes I think this backport needs.

@joakime
Issue #6072 - disabling flaky test (fixed in 9.4.x)
2112daf 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime merged commit c3d3540 into jetty-9.3.x Sep 20, 2021
Jetty 9.3.30 FROZEN automation moved this from In progress to Done Sep 20, 2021
@joakime joakime deleted the jetty-9.3.x-6072-backport-large-tls-fix branch September 20, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@sbordet sbordet sbordet approved these changes

@olamy olamy Awaiting requested review from olamy

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side End-of-Life release Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 9.3.30 FROZEN
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joakime @gregw @sbordet @olamy