Fixes #6693 - FastCGI review #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed code supporting multiplex in the client. - Removed code supporting multiplex in the server. - Reworked the server-side processing of a request, now more similar to HTTP/1.1. - Improved javadocs. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Closed
Fixed javadocs. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
previously approved these changes
Sep 3, 2021
jetty-fcgi/fcgi-client/src/main/java/org/eclipse/jetty/fcgi/parser/Parser.java
Outdated
Show resolved
Hide resolved
jetty-fcgi/fcgi-server/src/main/java/org/eclipse/jetty/fcgi/server/HttpChannelOverFCGI.java
Outdated
Show resolved
Hide resolved
jetty-fcgi/fcgi-server/src/main/java/org/eclipse/jetty/fcgi/server/HttpChannelOverFCGI.java
Outdated
Show resolved
Hide resolved
jetty-fcgi/fcgi-server/src/main/java/org/eclipse/jetty/fcgi/server/HttpChannelOverFCGI.java
Show resolved
Hide resolved
jetty-fcgi/fcgi-server/src/main/java/org/eclipse/jetty/fcgi/server/HttpChannelOverFCGI.java
Outdated
Show resolved
Hide resolved
jetty-fcgi/fcgi-server/src/main/java/org/eclipse/jetty/fcgi/server/HttpChannelOverFCGI.java
Show resolved
Hide resolved
jetty-fcgi/fcgi-server/src/main/java/org/eclipse/jetty/fcgi/server/ServerFCGIConnection.java
Show resolved
Hide resolved
Updates after review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Reviewer approved
to Review in progress
Sep 3, 2021
gregw
reviewed
Sep 6, 2021
| private final HttpFields.Mutable fields = HttpFields.build(); | ||
| private final Dispatcher dispatcher; | ||
| private HttpInput.Content _specialContent; |
There was a problem hiding this comment.
other fields here are a bit of a mix of _ and no _. Can you correct them all to be consistent.
| if (!hasContent()) | ||
| return null; | ||
|
|
||
| HttpInput.Content content = _contentQueue.poll(); |
There was a problem hiding this comment.
Do we still need a queue here? onContent now always returns true to ensure back pressure, so we should not get more than one content.
Also should we rename the action in the parse from ASYNC to IN_CONTENT?
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Review in progress
to Reviewer approved
Sep 6, 2021
lorban
previously approved these changes
Sep 6, 2021
Updates after review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Reviewer approved
to Review in progress
Sep 6, 2021
Jetty 10.0.7/11.0.7 FROZEN
automation
moved this from Review in progress
to Reviewer approved
Sep 7, 2021
gregw
approved these changes
Sep 7, 2021
lorban
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simone Bordet simone.bordet@gmail.com