Issue #6601 - fix JPMS issues for websocket-core-common #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…dObjectFactory Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Aug 30, 2021
There was a problem hiding this comment.
Typical Maven structure for child modules is to repeat the parent directory name, or drop it entirely, so:
test-jpms
`- test-jpms-websocket-core
Right now the child directory is test-websocket-core so I would add jpms.
Also make sure you have a newline at EOF.
tests/test-jpms/test-websocket-core/src/test/java/WebSocketCoreJpmsTest.java
Outdated
Show resolved
Hide resolved
tests/test-jpms/test-websocket-core/src/main/java/org/example/websocket/MyFrameHandler.java
Outdated
Show resolved
Hide resolved
tests/test-jpms/test-websocket-core/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6601
DecoratedObjectFactory