Fixes #6652 - Improve ReservedThreadExecutor dump. #6653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now adding/removing ReservedThread instances to _threads only in reservedWait(). In this way the window of time in which they can be caught for a dump() is shorter, producing more accurate dumps. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Fixed test failing due to the changes in toString(). Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
requested changes
Aug 24, 2021
| finally | ||
| { | ||
| // No longer a reserved thread. | ||
| _threads.remove(this); |
There was a problem hiding this comment.
I don't like this extra work here. We want minimum time and effort between allocating a reserved thread and it acting on the task.
Making it modifyf the _threads collection here just wastes time. See my alternative cleanup of dump in #6658
+ Revert RTE to not mutate `_threads` on critical path. + filter `_threads` in dump and doStop (cherry picked from commit 69d7add)
Incorporate suggestions from review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Updated doStop() to interrupt non-null threads. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
approved these changes
Aug 24, 2021
sbordet
deleted the
jetty-9.4.x-6652-improve-reserved-thread-executor-dump
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now adding/removing ReservedThread instances to _threads only in reservedWait().
In this way the window of time in which they can be caught for a dump() is shorter, producing more accurate dumps.
Signed-off-by: Simone Bordet simone.bordet@gmail.com