New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ipv6 test for #6624 #6625
Conversation
Temp disable of test that is breaking the build.
CI failure is unrelated flakey test. See #6626 |
@@ -1014,6 +1013,7 @@ public void testForcedNonDomainSNI() throws Exception | |||
.send(); | |||
assertEquals(HttpStatus.OK_200, response2.getStatus()); | |||
|
|||
/* TODO Fix. See #6624 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about marking the test method with @DisabledOnJre({JRE.JAVA_17})
easier to search for common annotation @Disabled*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the test is parameterized and tests other stuff. So the test is not disabled, just the IPv6 part of it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is its hard to keep track of TODOs because we have so many of them in the code. So it might just get lost and never be fixed, maybe if you at least commented in the issue as a reminder so it is not forgotten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. This PR does not close the issue, so the issue will remain open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer usage of the annotation @Disabled
Temp disable of ipv6 test for #6624, that is breaking the build.