Issue #6617 - add support for the client_secret_basic authentication method #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…ctor Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Aug 17, 2021
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdConfiguration.java
Show resolved
Hide resolved
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdCredentials.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Aug 18, 2021
sbordet
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6617
Add support for the
client_secret_basicauthentication method defined in https://openid.net/specs/openid-connect-core-1_0.html#ClientAuthentication.I have defined a field
OpenIdConfiguration.authMethodas aString, this is to eventually add support for the other auth methods such asclient_secret_jwt(see issue #4310).