Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6602 - Do not leak WebSocket SessionTracker if closed in onOpen #6604

Merged
merged 1 commit into from Aug 16, 2021
Merged

Issue #6602 - Do not leak WebSocket SessionTracker if closed in onOpen #6604

merged 1 commit into from Aug 16, 2021

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented Aug 12, 2021 •
edited by joakime

Fixes #6602

  • only notify the session listeners of onOpen if the onOpen call succeeds without closing the session.

@lachlan-roberts
Issue #6602 - do not invoke SessionListener onOpen if session has bee…
646707b 
…n closed in OnOpen

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts added this to In progress in Jetty 10.0.7/11.0.7 FROZEN via automation Aug 16, 2021
@lachlan-roberts lachlan-roberts merged commit b8370f6 into jetty-10.0.x Aug 16, 2021
Jetty 10.0.7/11.0.7 FROZEN automation moved this from In progress to Done Aug 16, 2021
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-6602-SessionTrackerLeak branch August 16, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime joakime approved these changes

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 10.0.7/11.0.7 FROZEN
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SessionTracker memory leak on WebSockets that close immediately
4 participants
@lachlan-roberts @gregw @joakime @sbordet