Issue #6554 - create the DefaultIdentityService even if no realmName is provided #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is provided Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…enticator for null AuthMethod Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
requested review from
janbartel and
gregw
and removed request for
janbartel
janbartel
requested changes
Aug 6, 2021
| @@ -62,7 +62,7 @@ public Authenticator getAuthenticator(Server server, ServletContext context, Aut | |||
| String auth = configuration.getAuthMethod(); | |||
| Authenticator authenticator = null; | |||
|
|
|||
| if (auth == null || Constraint.__BASIC_AUTH.equalsIgnoreCase(auth)) | |||
| if (Constraint.__BASIC_AUTH.equalsIgnoreCase(auth)) | |||
There was a problem hiding this comment.
Is there a test for this case?
There was a problem hiding this comment.
@lachlan-roberts I agree that we need at least some simple test that checks a DIS is created if there is no realm. Ie not necessarily testing this specific line, but testing the PR in general.
gregw
requested changes
Aug 24, 2021
| @@ -62,7 +62,7 @@ public Authenticator getAuthenticator(Server server, ServletContext context, Aut | |||
| String auth = configuration.getAuthMethod(); | |||
| Authenticator authenticator = null; | |||
|
|
|||
| if (auth == null || Constraint.__BASIC_AUTH.equalsIgnoreCase(auth)) | |||
| if (Constraint.__BASIC_AUTH.equalsIgnoreCase(auth)) | |||
There was a problem hiding this comment.
@lachlan-roberts I agree that we need at least some simple test that checks a DIS is created if there is no realm. Ie not necessarily testing this specific line, but testing the PR in general.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Aug 25, 2021
janbartel
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6554
DefaultIdentityServiceeven if no realmName is providedDefaultAuthenticatorFactoryshould not createBasicAuthenticatorfor null AuthMethod