Issue #6553 - give 401 response if UNAUTHENTICATED and auth is mandatory #6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
previously requested changes
Aug 5, 2021
jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Show resolved
Hide resolved
gregw
requested changes
Aug 6, 2021
jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Outdated
Show resolved
Hide resolved
jetty-security/src/main/java/org/eclipse/jetty/security/SecurityHandler.java
Show resolved
Hide resolved
…for DeferredAuth Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…6553-SecurityHandler
gregw
approved these changes
Aug 24, 2021
|
@gregw do you think this should be brought back to 9.4? |
|
@lachlan-roberts if we updated the JASPI auth in 9.4 to be usable, then yes this needs to be backported. But if the recent jaspi changes were 10 only, then I say leave 9.4 as is. |
|
@gregw this is not related to the JASPI updates. Looks like the existing JASPI implementation in 9.4 to can also return |
|
OK then I think backport is needed. |
lachlan-roberts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6553
If
AuthenticatorreturnsUNAUTHENTICATEDand auth is mandatory then we should return 403 response.