Issue #6556 Ensure context classloader set when operating on memcache. #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <janb@webtide.com>
olamy
requested changes
Jul 28, 2021
...ched-sessions/src/main/java/org/eclipse/jetty/memcached/session/MemcachedSessionDataMap.java
Outdated
Show resolved
Hide resolved
olamy
previously approved these changes
Jul 29, 2021
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
olamy
previously approved these changes
Jul 29, 2021
gregw
requested changes
Jul 30, 2021
|
|
||
| /** | ||
| * Return the result if completed successfully | ||
| * or rethrow the Exception |
There was a problem hiding this comment.
Need to be clearer here that the Exception thrown is not wrapped with ExecutionException like it is with get().
jetty-util/src/main/java/org/eclipse/jetty/util/FuturePromise.java
Outdated
Show resolved
Hide resolved
...ched-sessions/src/main/java/org/eclipse/jetty/memcached/session/MemcachedSessionDataMap.java
Show resolved
Hide resolved
Signed-off-by: Jan Bartel <janb@webtide.com>
gregw
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6556