New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non blocking ReservedThreadExecutor #6535
Commits on Jul 6, 2021
Commits on Jul 7, 2021
Commits on Jul 12, 2021
-
-
-
Never block waiting for reserved thread. Dump reserved thread stack if it does not make the rendezvous
Commits on Jul 13, 2021
-
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-64…
…95-ReservedThreadExecutor
-
Additional logging to try to catch the issue.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
-
Additional logging to try to catch the issue, take 2.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
-
Additional logging to try to catch the issue, take 3.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
-
Additional logging to try to catch the issue, take 3.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Commits on Jul 14, 2021
-
If a reserved thread does not rendezvous, put it back on the bottom of the stack.
-
Even more paranoid checks: + test if an missed offer was for a thread that removed itself from the stack + test if a reserved thread is already on the stack before adding it.
Commits on Jul 16, 2021
-
Even more paranoid checks: + try to poll after remove to check for race in remove
Commits on Jul 19, 2021
-
Even more paranoid checks: + try to poll after remove to check for race in remove
Commits on Jul 22, 2021
-
This is a new approach to #6495. A call to offer must never block, nor even yield, since to do so give an opportunity for the allocated CPU core to change, defeating the whole purpose of the class. There is also some reasonable level of diagnostic warnings if a reserved thread misses too many offers consecutively, based on tracking the state of the reserved thread.
-
Use MAX_VALUE rather than -1 as the stopped marker value.
Commits on Jul 23, 2021
-
Remove the stack data structure entirely. ReservedThreads all poll the same SynchronousQueue and tryExecute does a non blocking offer.
-
Remember last time we hit zero reserved threads
Commits on Jul 24, 2021
Commits on Jul 25, 2021
Commits on Jul 27, 2021
-
Merge branch 'jetty-9.4.x-6495-ReservedThreadExecutor3' of github.com…
…:eclipse/jetty.project into jetty-9.4.x-6495-ReservedThreadExecutor3