Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6520 - Fixing ErrorHandler output of text/html #6525

Merged
merged 1 commit into from Jul 17, 2021

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jul 16, 2021

  • Updating tests to ensure that output is xml verified
  • Updating output to use <hr> element properly.

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

+ Updating tests to ensure that output is xml verified
+ Updating output to use `<hr>` element properly.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added the Bug For general bugs on Jetty side label Jul 16, 2021
@joakime joakime requested a review from sbordet July 16, 2021 19:02
@joakime joakime self-assigned this Jul 16, 2021
@joakime joakime added this to In progress in Jetty 9.4.44 FROZEN via automation Jul 16, 2021
@joakime joakime linked an issue Jul 16, 2021 that may be closed by this pull request
@joakime
Copy link
Contributor Author

joakime commented Jul 16, 2021

Not covered by Eclipse ECA? Riiiiight. 🙄

@joakime
Copy link
Contributor Author

joakime commented Jul 16, 2021

Ok, I kicked the eca validation and it's happy again.

Jetty 9.4.44 FROZEN automation moved this from In progress to Reviewer approved Jul 16, 2021
@joakime joakime merged commit 6782b24 into jetty-9.4.x Jul 17, 2021
Jetty 9.4.44 FROZEN automation moved this from Reviewer approved to Done Jul 17, 2021
@joakime joakime deleted the jetty-9.4.x-6520-errorhandler-valid-xhtml-xml branch July 17, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Error page has HTML error when writePoweredBy is enabled.
2 participants