Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6487 - expose ServletHolder in ChainEnd #6488

Merged
merged 1 commit into from Jul 8, 2021
Merged

Issue #6487 - expose ServletHolder in ChainEnd #6488

merged 1 commit into from Jul 8, 2021

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jun 30, 2021 •
edited by gregw

Fix #6487
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

@joakime
Issue #6487 - expose ServletHolder in ChainEnd
1dd66ad 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Jun 30, 2021
@joakime joakime requested a review from gregw June 30, 2021 17:26
@joakime joakime self-assigned this Jun 30, 2021
@joakime joakime added this to In progress in Jetty 9.4.44 FROZEN via automation Jun 30, 2021
Jetty 9.4.44 FROZEN automation moved this from In progress to Reviewer approved Jun 30, 2021
gregw
gregw approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@joakime joakime merged commit 2cf5428 into jetty-9.4.x Jul 8, 2021
Jetty 9.4.44 FROZEN automation moved this from Reviewer approved to Done Jul 8, 2021
@joakime joakime deleted the jetty-9.4.x-6487-expose-chainend-servletholder branch July 8, 2021 21:19
@joakime joakime mentioned this pull request Jul 8, 2021
Merged
@gregw gregw linked an issue Sep 20, 2021 that may be closed by this pull request
Expose ServletHolder getter in ServletHandler$ChainEnd for auditing libraries to use #6487
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees

@joakime joakime

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 9.4.44 FROZEN
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose ServletHolder getter in ServletHandler$ChainEnd for auditing libraries to use
2 participants
@joakime @gregw