Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6464 - fix logging capture modules #6465

Merged
merged 1 commit into from Jun 23, 2021

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jun 23, 2021

  • Adding distribution tests for logging module combinations.

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

+ Adding distribution tests for logging module combinations.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added the Bug For general bugs on Jetty side label Jun 23, 2021
@joakime joakime requested a review from janbartel June 23, 2021 12:36
@joakime joakime self-assigned this Jun 23, 2021
@joakime joakime linked an issue Jun 23, 2021 that may be closed by this pull request
@joakime
Copy link
Contributor Author

joakime commented Jun 23, 2021

@janbartel @gregw @lachlan-roberts I think this is useful to merge into the pending release. WDYT?

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .
Ask @lachlan-roberts as release manager if this can sneak in.

@lachlan-roberts lachlan-roberts added this to In progress in Jetty 10.0.6/11.0.6 FROZEN via automation Jun 23, 2021
@lachlan-roberts
Copy link
Contributor

No problem for this to make the current release.

@joakime
Copy link
Contributor Author

joakime commented Jun 23, 2021

I'll merge it into 10 and then forward to 11.

@joakime joakime merged commit 0b96734 into jetty-10.0.x Jun 23, 2021
Jetty 10.0.6/11.0.6 FROZEN automation moved this from In progress to Done Jun 23, 2021
@joakime joakime deleted the jetty-10.0.x-6464-log4j1-download-location branch June 23, 2021 23:12
@joakime
Copy link
Contributor Author

joakime commented Jun 23, 2021

@lachlan-roberts done, and merged all the way thru to Jetty 11.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Wrong files/lib definitions in certain *-capture.mod files?
4 participants