Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6410 - Use SocketAddress instead of InetSocketAddress. #6414

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Jun 15, 2021

Removed usages of InetSocketAddress in method signatures where possible.
Deprecated old methods, and added new methods with SocketAddress.

Signed-off-by: Simone Bordet simone.bordet@gmail.com

Removed usages of InetSocketAddress in method signatures where possible.
Deprecated old methods, and added new methods with SocketAddress.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested review from gregw and joakime June 15, 2021 14:06
Restored fake socket addresses in ByteArrayEndPoint,
as too many tests depend on these fake socket addresses.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Fixed handling of the LOCAL command: everything past it must be ignored as per specification.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@joakime joakime linked an issue Jun 15, 2021 that may be closed by this pull request
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in ByteArrayEndPoint had me confused for a hot minute, but i'm happy with these changes.

BTW, You fixed Issue #2134 with this PR as well.

@joakime joakime added this to In progress in Jetty 10.0.6/11.0.6 FROZEN via automation Jun 15, 2021
@joakime joakime added the Bug For general bugs on Jetty side label Jun 15, 2021
Jetty 10.0.6/11.0.6 FROZEN automation moved this from In progress to Reviewer approved Jun 16, 2021
@sbordet sbordet merged commit b8d6e3f into jetty-10.0.x Jun 17, 2021
Jetty 10.0.6/11.0.6 FROZEN automation moved this from Reviewer approved to Done Jun 17, 2021
@sbordet sbordet deleted the jetty-10.0.x-6410-socketaddress-insteadof-inetsocketaddress branch June 17, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Ensure Jetty IO uses SocketAddress instead of InetSocketAddress
3 participants