New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6407 - Fix URI validation for WebSocket ClientUpgradeRequest #6411
Merged
lachlan-roberts
merged 3 commits into
jetty-10.0.x
from
jetty-10.0.x-6407-ClientUpgradeRequestUri
Jun 23, 2021
Merged
Issue #6407 - Fix URI validation for WebSocket ClientUpgradeRequest #6411
lachlan-roberts
merged 3 commits into
jetty-10.0.x
from
jetty-10.0.x-6407-ClientUpgradeRequestUri
Jun 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecate it Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Jun 15, 2021
...-websocket/websocket-jetty-api/src/main/java/org/eclipse/jetty/websocket/api/util/WSURI.java
Show resolved
Hide resolved
...-websocket/websocket-jetty-api/src/main/java/org/eclipse/jetty/websocket/api/util/WSURI.java
Show resolved
Hide resolved
...cket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/ClientUpgradeRequest.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit.
...cket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/ClientUpgradeRequest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
force-pushed
the
jetty-10.0.x-6407-ClientUpgradeRequestUri
branch
from
June 15, 2021 15:00
db279b8
to
402d79f
Compare
sbordet
approved these changes
Jun 15, 2021
joakime
previously requested changes
Jun 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove all of requestURI internals from ClientUpgradeRequest, and deprecate the constructor and getters.
...cket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/ClientUpgradeRequest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6407
ClientUpgradeRequest
.URI
is not used and the validation is repeated after calling theWebSocketClient.connect()
method.